From 2a442c1997cbd5b125a47727c86ecb14a27d1c01 Mon Sep 17 00:00:00 2001 From: Rasmus Dahlberg Date: Wed, 25 Nov 2020 13:01:03 +0100 Subject: fixed file typo and added more tests - Added missing continue in TestNewGetEntries(), and checked all values in the returned request - Added TestNewGetProofByHashResponse() --- reqres.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'reqres.go') diff --git a/reqres.go b/reqres.go index 8e1c454..14729ea 100644 --- a/reqres.go +++ b/reqres.go @@ -114,12 +114,15 @@ func (lp *LogParameters) newGetProofByHashRequest(httpRequest *http.Request) (*G return nil, fmt.Errorf("bad tree_size parameter: %v", err) } if size < 1 { - return nil, fmt.Errorf("bad tree_size parameter: negative value") + return nil, fmt.Errorf("bad tree_size parameter: must be larger than zero") } hash, err := deb64(httpRequest.FormValue("hash")) if err != nil { return nil, fmt.Errorf("bad hash parameter: %v", err) } + if len(hash) != lp.HashType.Size() { + return nil, fmt.Errorf("bad hash parameter: must be %d bytes", lp.HashType.Size()) + } return &GetProofByHashRequest{TreeSize: size, Hash: hash}, nil } -- cgit v1.2.3