aboutsummaryrefslogtreecommitdiff
path: root/issues/refactor-pkg-state-single.md
blob: 78a4e6c8217dfaec2b0178a561f777fe3bba9423 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
**Title:** Refactor pkg/state/single.go </br>
**Date:** 2021-12-20 </br>

# Summary
Remove unwanted dependencies and resolve minor TODOs in `pkg/state/single.go`.

# Description
Some refactoring is needed in `pkg/state/single.go`.  In more detail, the
following dependencies are overkill and should ideally be removed:
- "github.com/google/certificate-transparency-go/schedule"
- "reflect"

There are also two TODO prints in the code:
```
$ git g TODO
single.go
115: return fmt.Errorf("signature-signer pair is a duplicate") // TODO: maybe not an error
154: sm.cosignatures = make(map[types.Hash]*types.Signature, 0) // TODO: on repeat we might want to not zero this
```