1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
|
package stfe
import (
"bytes"
//"fmt"
"reflect"
"testing"
//"testing/iotest"
"net/http"
"github.com/system-transparency/stfe/pkg/testdata"
"github.com/system-transparency/stfe/pkg/types"
)
func TestParseAddEntryV1Request(t *testing.T) {
lp := newLogParameters(t, nil)
for _, table := range []struct {
description string
breq *bytes.Buffer
wantErr bool
}{
{
description: "invalid: nothing to unpack",
breq: bytes.NewBuffer(nil),
wantErr: true,
},
{
description: "invalid: not a signed checksum entry",
breq: testdata.AddCosignatureBuffer(t, testdata.DefaultSth(t, testdata.Ed25519VkLog), &testdata.Ed25519SkWitness, &testdata.Ed25519VkWitness),
wantErr: true,
},
{
description: "invalid: untrusted submitter", // only testdata.Ed25519VkSubmitter is registered by default in newLogParameters()
breq: testdata.AddSignedChecksumBuffer(t, testdata.Ed25519SkSubmitter2, testdata.Ed25519VkSubmitter2),
wantErr: true,
},
{
description: "invalid: signature does not cover message",
breq: testdata.AddSignedChecksumBuffer(t, testdata.Ed25519SkSubmitter2, testdata.Ed25519VkSubmitter),
wantErr: true,
},
{
description: "valid",
breq: testdata.AddSignedChecksumBuffer(t, testdata.Ed25519SkSubmitter, testdata.Ed25519VkSubmitter),
}, // TODO: add test case that disables submitter policy (i.e., unregistered namespaces are accepted)
} {
url := EndpointAddEntry.Path("http://example.com", lp.Prefix)
req, err := http.NewRequest("POST", url, table.breq)
if err != nil {
t.Fatalf("failed creating http request: %v", err)
}
req.Header.Set("Content-Type", "application/octet-stream")
_, err = lp.parseAddEntryV1Request(req)
if got, want := err != nil, table.wantErr; got != want {
t.Errorf("got errror %v but wanted %v in test %q: %v", got, want, table.description, err)
}
}
}
func TestParseAddCosignatureV1Request(t *testing.T) {
lp := newLogParameters(t, nil)
for _, table := range []struct {
description string
breq *bytes.Buffer
wantErr bool
}{
{
description: "invalid: nothing to unpack",
breq: bytes.NewBuffer(nil),
wantErr: true,
},
{
description: "invalid: not a cosigned sth",
breq: testdata.AddSignedChecksumBuffer(t, testdata.Ed25519SkSubmitter, testdata.Ed25519VkSubmitter),
wantErr: true,
},
{
description: "invalid: no cosignature",
breq: testdata.AddCosignatureBuffer(t, testdata.DefaultSth(t, testdata.Ed25519VkLog), &testdata.Ed25519SkWitness, nil),
wantErr: true,
},
{
description: "invalid: untrusted witness", // only testdata.Ed25519VkWitness is registered by default in newLogParameters()
breq: testdata.AddCosignatureBuffer(t, testdata.DefaultSth(t, testdata.Ed25519VkLog), &testdata.Ed25519SkWitness2, &testdata.Ed25519VkWitness2),
wantErr: true,
},
{
description: "invalid: signature does not cover message",
breq: testdata.AddCosignatureBuffer(t, testdata.DefaultSth(t, testdata.Ed25519VkLog), &testdata.Ed25519SkWitness2, &testdata.Ed25519VkWitness),
wantErr: true,
},
{
description: "valid",
breq: testdata.AddCosignatureBuffer(t, testdata.DefaultSth(t, testdata.Ed25519VkLog), &testdata.Ed25519SkWitness, &testdata.Ed25519VkWitness),
}, // TODO: add test case that disables witness policy (i.e., unregistered namespaces are accepted)
} {
url := EndpointAddCosignature.Path("http://example.com", lp.Prefix)
req, err := http.NewRequest("POST", url, table.breq)
if err != nil {
t.Fatalf("failed creating http request: %v", err)
}
req.Header.Set("Content-Type", "application/octet-stream")
_, err = lp.parseAddCosignatureV1Request(req)
if got, want := err != nil, table.wantErr; got != want {
t.Errorf("got errror %v but wanted %v in test %q: %v", got, want, table.description, err)
}
}
}
func TestNewGetConsistencyProofRequest(t *testing.T) {
lp := newLogParameters(t, nil)
for _, table := range []struct {
description string
req *types.GetConsistencyProofV1
wantErr bool
}{
{
description: "invalid: nothing to unpack",
req: nil,
wantErr: true,
},
{
description: "invalid: first must be larger than zero",
req: &types.GetConsistencyProofV1{First: 0, Second: 0},
wantErr: true,
},
{
description: "invalid: second must be larger than first",
req: &types.GetConsistencyProofV1{First: 2, Second: 1},
wantErr: true,
},
{
description: "valid",
req: &types.GetConsistencyProofV1{First: 1, Second: 2},
},
} {
var buf *bytes.Buffer
if table.req == nil {
buf = bytes.NewBuffer(nil)
} else {
buf = bytes.NewBuffer(marshal(t, *table.req))
}
url := EndpointGetConsistencyProof.Path("http://example.com", lp.Prefix)
req, err := http.NewRequest("POST", url, buf)
if err != nil {
t.Fatalf("failed creating http request: %v", err)
}
req.Header.Set("Content-Type", "application/octet-stream")
_, err = lp.parseGetConsistencyProofV1Request(req)
if got, want := err != nil, table.wantErr; got != want {
t.Errorf("got errror %v but wanted %v in test %q: %v", got, want, table.description, err)
}
}
}
func TestNewGetProofByHashRequest(t *testing.T) {
lp := newLogParameters(t, nil)
for _, table := range []struct {
description string
req *types.GetProofByHashV1
wantErr bool
}{
{
description: "invalid: nothing to unpack",
req: nil,
wantErr: true,
},
{
description: "invalid: no entry in an empty tree",
req: &types.GetProofByHashV1{TreeSize: 0, Hash: testdata.LeafHash},
wantErr: true,
},
{
description: "valid",
req: &types.GetProofByHashV1{TreeSize: 1, Hash: testdata.LeafHash},
},
} {
var buf *bytes.Buffer
if table.req == nil {
buf = bytes.NewBuffer(nil)
} else {
buf = bytes.NewBuffer(marshal(t, *table.req))
}
url := EndpointGetProofByHash.Path("http://example.com", lp.Prefix)
req, err := http.NewRequest("POST", url, buf)
if err != nil {
t.Fatalf("failed creating http request: %v", err)
}
req.Header.Set("Content-Type", "application/octet-stream")
_, err = lp.parseGetProofByHashV1Request(req)
if got, want := err != nil, table.wantErr; got != want {
t.Errorf("got errror %v but wanted %v in test %q: %v", got, want, table.description, err)
}
}
}
func TestParseGetEntriesV1Request(t *testing.T) {
lp := newLogParameters(t, nil)
for _, table := range []struct {
description string
req *types.GetEntriesV1
wantErr bool
wantReq *types.GetEntriesV1
}{
{
description: "invalid: nothing to unpack",
req: nil,
wantErr: true,
},
{
description: "invalid: start must be larger than end",
req: &types.GetEntriesV1{Start: 1, End: 0},
wantErr: true,
},
{
description: "valid: want truncated range",
req: &types.GetEntriesV1{Start: 0, End: uint64(testdata.MaxRange)},
wantReq: &types.GetEntriesV1{Start: 0, End: uint64(testdata.MaxRange) - 1},
},
{
description: "valid",
req: &types.GetEntriesV1{Start: 0, End: 0},
wantReq: &types.GetEntriesV1{Start: 0, End: 0},
},
} {
var buf *bytes.Buffer
if table.req == nil {
buf = bytes.NewBuffer(nil)
} else {
buf = bytes.NewBuffer(marshal(t, *table.req))
}
url := EndpointGetEntries.Path("http://example.com", lp.Prefix)
req, err := http.NewRequest("POST", url, buf)
if err != nil {
t.Fatalf("failed creating http request: %v", err)
}
req.Header.Set("Content-Type", "application/octet-stream")
output, err := lp.parseGetEntriesV1Request(req)
if got, want := err != nil, table.wantErr; got != want {
t.Errorf("got errror %v but wanted %v in test %q: %v", got, want, table.description, err)
}
if err != nil {
continue
}
if got, want := output, table.wantReq; !reflect.DeepEqual(got, want) {
t.Errorf("got request\n%v\n\tbut wanted\n%v\n\t in test %q", got, want, table.description)
}
}
}
func TestUnpackOctetPost(t *testing.T) {
for _, table := range []struct {
description string
req *http.Request
out interface{}
wantErr bool
}{
//{
// description: "invalid: cannot read request body",
// req: func() *http.Request {
// req, err := http.NewRequest(http.MethodPost, "", iotest.ErrReader(fmt.Errorf("bad reader")))
// if err != nil {
// t.Fatalf("must make new http request: %v", err)
// }
// return req
// }(),
// out: &types.StItem{},
// wantErr: true,
//}, // testcase requires Go 1.16
{
description: "invalid: cannot unmarshal",
req: func() *http.Request {
req, err := http.NewRequest(http.MethodPost, "", bytes.NewBuffer(nil))
if err != nil {
t.Fatalf("must make new http request: %v", err)
}
return req
}(),
out: &types.StItem{},
wantErr: true,
},
{
description: "valid",
req: func() *http.Request {
req, err := http.NewRequest(http.MethodPost, "", bytes.NewBuffer([]byte{0}))
if err != nil {
t.Fatalf("must make new http request: %v", err)
}
return req
}(),
out: &struct{ SomeUint8 uint8 }{},
},
} {
err := unpackOctetPost(table.req, table.out)
if got, want := err != nil, table.wantErr; got != want {
t.Errorf("got error %v but wanted %v in test %q", got, want, table.description)
}
}
}
func marshal(t *testing.T, out interface{}) []byte {
b, err := types.Marshal(out)
if err != nil {
t.Fatalf("must marshal: %v", err)
}
return b
}
|
