aboutsummaryrefslogtreecommitdiff
path: root/issues/refactor-pkg-state-single.md
diff options
context:
space:
mode:
authorRasmus Dahlberg <rasmus@mullvad.net>2021-12-20 20:11:22 +0100
committerRasmus Dahlberg <rasmus@mullvad.net>2021-12-20 20:11:22 +0100
commit04ca3b71764c0a958338ddacb92c2f474c5f4e78 (patch)
tree4f68af20ab2be4d7a1630c11113950df1c1e0809 /issues/refactor-pkg-state-single.md
parentdda238b9fc105219f220f0ec3b341b0c81b71301 (diff)
issues: Add issue refactor-pkg-state-single
Diffstat (limited to 'issues/refactor-pkg-state-single.md')
-rw-r--r--issues/refactor-pkg-state-single.md20
1 files changed, 20 insertions, 0 deletions
diff --git a/issues/refactor-pkg-state-single.md b/issues/refactor-pkg-state-single.md
new file mode 100644
index 0000000..78a4e6c
--- /dev/null
+++ b/issues/refactor-pkg-state-single.md
@@ -0,0 +1,20 @@
+**Title:** Refactor pkg/state/single.go </br>
+**Date:** 2021-12-20 </br>
+
+# Summary
+Remove unwanted dependencies and resolve minor TODOs in `pkg/state/single.go`.
+
+# Description
+Some refactoring is needed in `pkg/state/single.go`. In more detail, the
+following dependencies are overkill and should ideally be removed:
+- "github.com/google/certificate-transparency-go/schedule"
+- "reflect"
+
+There are also two TODO prints in the code:
+```
+$ git g TODO
+single.go
+115: return fmt.Errorf("signature-signer pair is a duplicate") // TODO: maybe not an error
+154: sm.cosignatures = make(map[types.Hash]*types.Signature, 0) // TODO: on repeat we might want to not zero this
+```
+