1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
|
package stfe
import (
"testing"
"github.com/system-transparency/stfe/namespace/testdata"
)
// TestEncDecStItem tests that valid StItems can be (un)marshaled, and that
// invalid ones in fact fail.
//
// Note: max limits for inclusion and consistency proofs are not tested.
// Note: TreeHeadV1 extensions are not tested (not used by stfe)
func TestEncDecStItem(t *testing.T) {
logIdSize := 35
signatureMin := 1
signatureMax := 65535
messageMax := 65535
nodeHashMin := 32
nodeHashMax := 255
packageMin := 1
packageMax := 255
checksumMin := 1
checksumMax := 64
for _, table := range []struct {
description string
item *StItem
wantErr bool
}{
// signed_tree_head_v1
{
description: "too short log id",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), make([]byte, logIdSize-1), testSignature),
wantErr: true,
},
{
description: "too large log id",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), make([]byte, logIdSize+1), testSignature),
wantErr: true,
},
{
description: "ok log id: min and max",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), testLogId, testSignature),
},
{
description: "too short signature",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), testLogId, make([]byte, signatureMin-1)),
wantErr: true,
},
{
description: "too large signature",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), testLogId, make([]byte, signatureMax+1)),
wantErr: true,
},
{
description: "ok signature: min",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), testLogId, make([]byte, signatureMin)),
},
{
description: "ok signature: max",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), testLogId, make([]byte, signatureMax)),
},
{
description: "too short root hash",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMin-1))), testLogId, testSignature),
wantErr: true,
},
{
description: "too large root hash",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMax+1))), testLogId, testSignature),
wantErr: true,
},
{
description: "ok root hash: min",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMin))), testLogId, testSignature),
},
{
description: "ok root hash: min",
item: NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMax))), testLogId, testSignature),
},
// signed_debug_info_v1
{
description: "too short log id",
item: NewSignedDebugInfoV1(make([]byte, logIdSize-1), testMessage, testSignature),
wantErr: true,
},
{
description: "too large log id",
item: NewSignedDebugInfoV1(make([]byte, logIdSize+1), testMessage, testSignature),
wantErr: true,
},
{
description: "ok log id: min and max",
item: NewSignedDebugInfoV1(testLogId, testMessage, testSignature),
},
{
description: "too large message",
item: NewSignedDebugInfoV1(testLogId, make([]byte, messageMax+1), testSignature),
wantErr: true,
},
{
description: "ok message: max",
item: NewSignedDebugInfoV1(testLogId, make([]byte, messageMax), testSignature),
},
{
description: "too short signature",
item: NewSignedDebugInfoV1(testLogId, testMessage, make([]byte, signatureMin-1)),
wantErr: true,
},
{
description: "too large signature",
item: NewSignedDebugInfoV1(testLogId, testMessage, make([]byte, signatureMax+1)),
wantErr: true,
},
{
description: "ok signature: min",
item: NewSignedDebugInfoV1(testLogId, testMessage, make([]byte, signatureMin)),
},
{
description: "ok signature: max",
item: NewSignedDebugInfoV1(testLogId, testMessage, make([]byte, signatureMax)),
},
// consistency_proof_v1
{
description: "too short log id",
item: NewConsistencyProofV1(make([]byte, logIdSize-1), testTreeSize, testTreeSizeLarger, testProof),
wantErr: true,
},
{
description: "too large log id",
item: NewConsistencyProofV1(make([]byte, logIdSize+1), testTreeSize, testTreeSizeLarger, testProof),
wantErr: true,
},
{
description: "ok log id: min and max",
item: NewConsistencyProofV1(testLogId, testTreeSize, testTreeSizeLarger, testProof),
},
{
description: "too small node hash in proof",
item: NewConsistencyProofV1(testLogId, testTreeSize, testTreeSizeLarger, [][]byte{make([]byte, nodeHashMin-1)}),
wantErr: true,
},
{
description: "too large node hash in proof",
item: NewConsistencyProofV1(testLogId, testTreeSize, testTreeSizeLarger, [][]byte{make([]byte, nodeHashMax+1)}),
wantErr: true,
},
{
description: "ok proof: min node hash",
item: NewConsistencyProofV1(testLogId, testTreeSize, testTreeSizeLarger, [][]byte{make([]byte, nodeHashMin)}),
},
{
description: "ok proof: max node hash",
item: NewConsistencyProofV1(testLogId, testTreeSize, testTreeSizeLarger, [][]byte{make([]byte, nodeHashMin)}),
},
{
description: "ok proof: empty",
item: NewConsistencyProofV1(testLogId, testTreeSize, testTreeSizeLarger, [][]byte{}),
},
// inclusion_proof_v1
{
description: "too short log id",
item: NewInclusionProofV1(make([]byte, logIdSize-1), testTreeSize, testIndex, testProof),
wantErr: true,
},
{
description: "too large log id",
item: NewInclusionProofV1(make([]byte, logIdSize+1), testTreeSize, testIndex, testProof),
wantErr: true,
},
{
description: "ok log id: min and max",
item: NewInclusionProofV1(testLogId, testTreeSize, testIndex, testProof),
},
{
description: "too short node hash in proof",
item: NewInclusionProofV1(testLogId, testTreeSize, testIndex, [][]byte{make([]byte, nodeHashMin-1)}),
wantErr: true,
},
{
description: "too large node hash in proof",
item: NewInclusionProofV1(testLogId, testTreeSize, testIndex, [][]byte{make([]byte, nodeHashMax+1)}),
wantErr: true,
},
{
description: "ok proof: min node hash",
item: NewInclusionProofV1(testLogId, testTreeSize, testIndex, [][]byte{make([]byte, nodeHashMin)}),
},
{
description: "ok proof: max node hash",
item: NewInclusionProofV1(testLogId, testTreeSize, testIndex, [][]byte{make([]byte, nodeHashMax)}),
},
{
description: "ok proof: empty",
item: NewInclusionProofV1(testLogId, testTreeSize, testIndex, [][]byte{}),
},
// checksum_v1
{
description: "too short package",
item: NewChecksumV1(make([]byte, packageMin-1), testChecksum, mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
wantErr: true,
},
{
description: "too large package",
item: NewChecksumV1(make([]byte, packageMax+1), testChecksum, mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
wantErr: true,
},
{
description: "ok package: min",
item: NewChecksumV1(make([]byte, packageMin), testChecksum, mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
},
{
description: "ok package: max",
item: NewChecksumV1(make([]byte, packageMax), testChecksum, mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
},
{
description: "too short checksum",
item: NewChecksumV1(testPackage, make([]byte, checksumMin-1), mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
wantErr: true,
},
{
description: "too large checksum",
item: NewChecksumV1(testPackage, make([]byte, checksumMax+1), mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
wantErr: true,
},
{
description: "ok checksum: min",
item: NewChecksumV1(testPackage, make([]byte, checksumMin), mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
},
{
description: "ok checksum: max",
item: NewChecksumV1(testPackage, make([]byte, checksumMax), mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)),
}, // namespace (un)marshal is already tested in its own package (skip)
{
description: "ok cosigned sth",
item: NewCosignedTreeHeadV1(
NewSignedTreeHeadV1(NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, testNodeHash)), testLogId, testSignature).SignedTreeHeadV1,
[]SignatureV1{
SignatureV1{
*mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk),
testSignature,
},
},
),
}, // TODO: the only thing that is not tested elsewhere for cosigned sth is bound on signature. Unify signature into a type => some tests go away.
} {
b, err := table.item.MarshalB64()
if err != nil && !table.wantErr {
t.Errorf("failed marshaling StItem(%s) in test %q: %v", table.item.Format, table.description, err)
} else if err == nil && table.wantErr {
t.Errorf("succeeded marshaling StItem(%s) in test %q but want failure", table.item.Format, table.description)
}
if err != nil || table.wantErr {
continue // nothing to unmarshal
}
var item StItem
if err := item.UnmarshalB64(b); err != nil {
t.Errorf("failed unmarshaling StItem(%s) in test %q: %v", table.item.Format, table.description, err)
}
}
}
// TestTreeHeadMarshal tests that valid tree heads can be marshaled and that
// invalid ones cannot.
//
// Note: TreeHeadV1 extensions are not tested (not used by stfe)
func TestTreeHeadMarshal(t *testing.T) {
nodeHashMin := 32
nodeHashMax := 255
for _, table := range []struct {
description string
th *TreeHeadV1
wantErr bool
}{
{
description: "too short root hash",
th: NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMin-1))),
wantErr: true,
},
{
description: "too large root hash",
th: NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMax+1))),
wantErr: true,
},
{
description: "ok tree head: min node hash",
th: NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMin))),
},
{
description: "ok tree head: max node hash",
th: NewTreeHeadV1(makeTrillianLogRoot(t, testTimestamp, testTreeSize, make([]byte, nodeHashMax))),
},
} {
if _, err := table.th.Marshal(); err != nil && !table.wantErr {
t.Errorf("failed marshaling in test %q: %v", table.description, err)
} else if err == nil && table.wantErr {
t.Errorf("succeeded marshaling but wanted error in test %q: %v", table.description, err)
}
}
}
// TestStItemUnmarshal tests that invalid ST items cannot be unmarshaled
func TestStItemUnmarshalFailure(t *testing.T) {
b, err := NewChecksumV1(testPackage, testChecksum, mustNewNamespaceEd25519V1(t, testdata.Ed25519Vk)).Marshal()
if err != nil {
t.Errorf("must marshal ChecksumV1 StItem: %v", err)
return
}
var checksum StItem
if err := checksum.Unmarshal(append(b[:], []byte{0}...)); err == nil {
t.Errorf("succeeded unmarshaling but wanted error: one extra byte")
}
if err := checksum.Unmarshal(append(b[:], b[:]...)); err == nil {
t.Errorf("succeeded unmarshaling but wanted error: one extra b")
}
if err := checksum.Unmarshal([]byte{0}); err == nil {
t.Errorf("succeeded unmarshaling but wanted error: just a single byte")
}
b[0] = byte(len(testPackage)) + 1 // will mess up the first length specifier
if err := checksum.Unmarshal(b); err == nil {
t.Errorf("succeeded unmarshaling but wanted error: bad length")
}
if err := checksum.UnmarshalB64("@" + b64(b[1:])); err == nil {
t.Errorf("succeded unmarshaling base64 but wanted error: bad byte")
}
}
|
